gator/paytolaugh
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Repair the picture-check button, broken by a $-quote in patch text

Browse source 
A literal $' in replacement text is consumed as a special pattern by the
patch API, which truncated the block mid-string and swallowed the
if (unfilmed) line with it. BROWSER_TESTS.md records this exact hazard.
The price is now built by concatenating the dollar sign separately so no
$-quote sequence appears in patch text at all.
This commit is contained in:
gator 2026-09-17 20:58:07 +00:00
parent ac4ece69a5
commit a1ededf9c5
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
trailer.html
View file

@ -423,7 +423,11 @@
+ '" title="Samples frames from every clip and asks what is wrong ' + '" title="Samples frames from every clip and asks what is wrong '
+ 'with the picture, then whether it matches the script.">' + 'with the picture, then whether it matches the script.">'
+ (es === "ready" ? "Check the picture again" : "Check the picture") + (es === "ready" ? "Check the picture again" : "Check the picture")
+ ' · + ' · ' + "$" + (filmed * 0.02).toFixed(2)
+ '</button>');
}
if (unfilmed && !undrawn)
out.push('<button type="button" class="btn primary" data-film="' + esc(meta.id) out.push('<button type="button" class="btn primary" data-film="' + esc(meta.id)
+ '">Film ' + (filmed ? 'the ' + unfilmed + ' remaining shots' : 'all ' + shots.length + ' shots') + '">Film ' + (filmed ? 'the ' + unfilmed + ' remaining shots' : 'all ' + shots.length + ' shots')
+ ' &middot; $' + (unfilmed * 0.75).toFixed(2) + '</button>'); + ' &middot; $' + (unfilmed * 0.75).toFixed(2) + '</button>');